Skip to content

feat: add learning plugin + obsidian study/project-doc#21

Open
arevlo-flow wants to merge 1 commit intoarevlo:mainfrom
arevlo-flow:arevlo.feat-add-learning-and-obsidian-commands
Open

feat: add learning plugin + obsidian study/project-doc#21
arevlo-flow wants to merge 1 commit intoarevlo:mainfrom
arevlo-flow:arevlo.feat-add-learning-and-obsidian-commands

Conversation

@arevlo-flow
Copy link
Contributor

Summary

  • Adds learning plugin (v2.0.0) with vocab and grammar commands for English/Spanish lookups
  • Adds obsidian study command for interactive document study with Q&A sessions
  • Adds obsidian project-doc command for adding Confluence document summaries to project files
  • Bumps obsidian plugin version to 1.6.0 with updated README

Changes

  • plugins/learning/ — New plugin with vocab and grammar slash commands
  • plugins/obsidian/commands/study.md — Interactive document study workflow
  • plugins/obsidian/commands/project-doc.md — Confluence-to-Obsidian project doc workflow
  • plugins/obsidian/.claude-plugin/plugin.json — Version bump to 1.6.0
  • plugins/obsidian/README.md — Updated with new commands, configurable paths, removed hardcoded vault path

Notes

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 71f1bef54f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +85 to +89
Configuration is stored in `~/.claude/obsidian-plugin.json`. On first use, any command will prompt you to set up your vault path.

To change this, edit the `VAULT_PATH` in `commands/capture.md`.
| Field | Used By | Description |
|-------|---------|-------------|
| `vault_path` | All commands | Absolute path to your Obsidian vault |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align config docs with capture command behavior

This section says the vault path in ~/.claude/obsidian-plugin.json is used by all commands and that any command will prompt to set it up, but /arevlo:obsidian:capture still hardcodes VAULT_PATH in plugins/obsidian/commands/capture.md without reading the config. If a user follows this README and sets a custom vault path, capture will write to the hardcoded location or fail, so the documentation is misleading and the command won’t work as described. Either update capture to read the config or narrow the README claim to only the new commands.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant