ADBDEV-6776 Restore PXF unit tests for external table #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and some of them works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PXF external table component contains a directory with unit tests. These tests
have not been updated for a while and seem to be broken now. However, ongoing
development can benefit from having unit tests ready to use.
The problem with these tests is that PXF heavily uses database internals, such
as strings, memory management, transaction states, etc. While PXF was part of
the core distribution, this was not an issue since the tests were integrated
into the GP unit test system. However, when PXF became an independent component
without references to the database source code, the problem arose. This was
perhaps the main reason the tests were abandoned.
This commit enables the tests to be built and run. However, many of the tests
remain disabled as the environment has changed significantly, and a considerable
amount of effort is still required to resurrect them. These tests have been
commented out, and compiler warnings will serve as a reminder that this work is
not yet finished.