-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add CharDisplay repository link #7426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A problem was found with your submission https://github.com/dshamany/CharDisplay ❌ ERROR: The repository has no tags. You need to create a release or tag that matches the |
|
Thanks for your interest in contributing to the Arduino Library Manager index @dshamany After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
per1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @dshamany. Thanks for your interest in contributing to the Arduino Library Manager.
I see the bot reported a problem with your submission that will block its acceptance:
A problem was found with your submission https://github.com/dshamany/CharDisplay
❌ ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.
Please fix the problem so we can proceed with your submission.
- Create a release or tag in the library repository.
- Add a comment here in the pull request thread that mentions @ArduinoBot.
After that, the automated checks will run again. Once those are passing, your library will be automatically added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
|
@ArduinoBot I have added a tag named |
|
Hello! I'm checking your submission again. |
|
❌ ERROR: Arduino Lint found errors with https://github.com/dshamany/CharDisplay: |
|
Thanks for your interest in contributing to the Arduino Library Manager index @dshamany After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
per1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#Hello @dshamany. I see the bot reported a problem with your submission that will block its acceptance:
ERROR: Library name CharDisplay is in use by a library in the Library Manager index. Each library must have a unique
name value. If your library is already in the index, use the "--library-manager update" flag.
See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
Please fix the problem so we can proceed with your submission.
You will need to do the following things:
- Change the value of the
nameproperty in the library'slibrary.propertiesmetadata file to a unique name not already in use by another library.
ⓘ You can search in the Arduino IDE Library Manager to determine whether a prospective name has already been taken. - Bump the value of the
versionproperty in the library'slibrary.propertiesmetadata file. - Create a new release or tag in the library repository.
- Add a comment here in the pull request thread that mentions @ArduinoBot.
After that, the automated checks will run again. Once those are passing, your library will be automatically added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
per1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of a tidy repository, I'm going to close this due to lack of activity.
@dshamany if you ever resolve the issue reported by the bot, please submit another pull request to add the library. Next time, prior to submitting a pull request please make sure you can reserve enough time to monitor the feedback and act promptly on any changes that are required. We expect the contributors to make the effort to complete their requests rather than leaving them in an incomplete state to clutter up this busy repository and consume finite human maintenance resources. The submission procedure is trivial, well documented, and streamlined; so this is not an unreasonable expectation.
I'll continue to monitor this thread, so feel free to let me know if you have any questions or concerns.
A Display Library with Icons from this tutorial:
https://lastminuteengineers.com/esp32-i2c-lcd-tutorial/