fix: event fd not being cleared #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardera
force-pushed
the
fix/epoll-performance
branch
4 times, most recently
from
26563b5 to
0cb929f
Compare
* rename real CAN test setup `pi3-can ==> double-can` * reformat * change expected txQueueLength to 1024 * change expected sendBufSize to 26*4096 * enable frame filter tests for hardware CAN setup as well
* throw StateError on Unexpected isolate message, rather than failing an assert * terminate event listener isolate in both double-can and vcan tests
Instead of waiting for the roundtrip with the "Stop" event to the event listener isolate to complete.
Makes test output a bit easier to follow. Also state can get a bit broken if other tests are executed while a previous test is still kinda running.
So they're not tested by melos run test. Also, invoke melos commands directly instead of via `dart pub global run melos`.
ardera
force-pushed
the
fix/epoll-performance
branch
from
d141c91 to
030c268
Compare
ardera
force-pushed
the
fix/epoll-performance
branch
from
030c268 to
ab2c8c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eventfd that was used to notify the event listener isolate of new/changed CAN sockets (or generally, file descriptors) was never cleared after the notification has been handled. That meant it was checked again all the time, causing high CPU usage.
Fixes #38