Updating deprecated scipy commands + PEP8 guidelines#31
Open
brunodpoliveira wants to merge 5 commits intoardamavi:masterfrom
Open
Updating deprecated scipy commands + PEP8 guidelines#31brunodpoliveira wants to merge 5 commits intoardamavi:masterfrom
brunodpoliveira wants to merge 5 commits intoardamavi:masterfrom
Conversation
brunodpoliveira
commented
Jan 18, 2021
brunodpoliveira
commented
- Deprecated Scipy commands have been updated [create_dataset and get_dataset]
- Files have been updated to comply with PEP8 guidelines [all files]
- Deprecated Scipy commands have been updated [create_dataset and get_dataset] - Files have been updated to comply with PEP8 guidelines [all files]
Changed scipy to imageio
Changed resize to cv2 resize
Simplyfying it to debug it
Making it so all the code follows PEP8 guidelines
|
Scipy 1.6.0 requires python 3.7+ you didn't update the readme to reflect what version of python to use but it's not 3.6 like the original. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.