Skip to content

chore(az.sb): use read-only list for az sb filter results #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fgheysels merged 1 commit into from
Jan 9, 2026
Merged

chore(az.sb): use read-only list for az sb filter results #495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Arcus.Testing.Messaging.ServiceBus/ServiceBusMessageFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,14 @@ public Task<bool> AnyAsync()
/// </param>
public async Task<bool> AnyAsync(CancellationToken cancellationToken)
{
List<ServiceBusReceivedMessage> messages = await ToListAsync(cancellationToken).ConfigureAwait(false);
var messages = await ToListAsync(cancellationToken).ConfigureAwait(false);
return messages.Count > 0;
}

/// <summary>
/// Gets the awaiter used to await the <see cref="ToListAsync()"/>.
/// </summary>
public TaskAwaiter<List<ServiceBusReceivedMessage>> GetAwaiter()
public TaskAwaiter<IReadOnlyList<ServiceBusReceivedMessage>> GetAwaiter()
{
return ToListAsync().GetAwaiter();
}
Expand All @@ -118,7 +118,7 @@ public TaskAwaiter<List<ServiceBusReceivedMessage>> GetAwaiter()
/// <remarks>
/// Deferred messages are also included as messages are peeked.
/// </remarks>
public Task<List<ServiceBusReceivedMessage>> ToListAsync()
public Task<IReadOnlyList<ServiceBusReceivedMessage>> ToListAsync()
{
return ToListAsync(CancellationToken.None);
}
Expand All @@ -132,7 +132,7 @@ public Task<List<ServiceBusReceivedMessage>> ToListAsync()
/// <param name="cancellationToken">
/// The optional <see cref="CancellationToken" /> instance to signal the request to cancel the operation.
/// </param>
public async Task<List<ServiceBusReceivedMessage>> ToListAsync(CancellationToken cancellationToken)
public async Task<IReadOnlyList<ServiceBusReceivedMessage>> ToListAsync(CancellationToken cancellationToken)
{
var options = new ServiceBusReceiverOptions
{
Expand Down
Loading