feat: add initial eventhubs test components #265
Conversation
✅ Deploy Preview for arcus-testing ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🧪 Code coverage summary
Great job! 😎 Your code coverage is higher than my caffeine levels! ☕ |
…b.com/stijnmoreels/arcus.testing into feature/add-eventhubs-test-components
|
stijnmoreels
added
feature
Use a read-only variant for the `ToList` result of the Azure Service Bus filtering. Follow-up of #265 where @fgheysels made my brain 🧠 work.
fgheysels
left a comment
fgheysels
left a comment
There was a problem hiding this comment.
I just have some suggestions
| ## Temporary hub | ||
| The `TemporaryEventHub` provides a solution when the integration test requires an Azure Event Hub during the test run. The test fixture creates a hub upon the setup of the fixture and deletes it again when the fixture disposes. | ||
|
|
||
| > ✨ Only when the test fixture was responsible for creating the hub, will the fixture delete the hub upon disposal. This follows the 'clean environment' testing principle that describes that after the test run, the test should revert the state back to its original state. |
There was a problem hiding this comment.
| > ✨ Only when the test fixture was responsible for creating the hub, will the fixture delete the hub upon disposal. This follows the 'clean environment' testing principle that describes that after the test run, the test should revert the state back to its original state. | |
| > ✨ When the test fixture was responsible for creating the hub, the fixture will delete the hub when the test disposes the fixture. This follows the 'clean environment' testing principle that describes that a test should revert the environment to its original state after the test has run. |
There was a problem hiding this comment.
'when the test has finished' might not always be when the 'test fixture disposes'. In most cases: yes, but that is more related to how the test was implemented. This remark only talks about the lifetime of the test fixture, independent on how it is used.
Plus, without mentioning 'dispose', I would imagine people thinking that it is some kind of 'aspect-oriented' stuff that gets hooked in.
There was a problem hiding this comment.
Ok, then change 'when the test has finished' to 'when the test has disposed' :)
There was a problem hiding this comment.
'Test disposes the fixture'? Added this suggestion.
Co-authored-by: Frederik Gheysels <frederik.gheysels@telenet.be>
Co-authored-by: Frederik Gheysels <frederik.gheysels@telenet.be>
3 participants
Adds initial testing components for interaction with Azure Event Hubs.
Relates to #90