docs(share_medical_records): fix PatientData field types to match code#62
Merged
arihantbansal merged 1 commit intoarcium-hq:mainfrom Mar 8, 2026
Merged
Conversation
The README showed gender as u8 (actually bool) and weight as u64 (actually u16), which would mislead developers working with the struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
genderfield type:u8→boolweightfield type:u64→u16Issue
The
PatientDatastruct in the README showed incorrect types that don't match the actual implementation inshare_medical_records/encrypted-ixs/src/lib.rs.Verification
Confirmed against actual struct definition:
Test plan