Skip to content

Conversation

@marc-romu
Copy link
Member

Description

This PR modifies the model capability validation to be more permissive with unregistered models. The changes allow users to use any model name, even if it's not explicitly listed in the provider's model registry, while still maintaining capability validation for known models.

Breaking Changes

No breaking changes. This is a non-breaking enhancement that makes the system more flexible.

Testing Done

  • Verified that unregistered models can be used successfully
  • Confirmed that known models still validate capabilities correctly
  • Tested with various model names and capability requirements
  • Verified that validation messages are appropriate for different scenarios

Checklist

  • This PR is focused on a single feature or bug fix
  • Version in Solution.props was updated, if necessary, and follows semantic versioning
  • CHANGELOG.md has been updated
  • PR title follows Conventional Commits format
  • PR description follows Pull Request Description Template

Copilot AI review requested due to automatic review settings October 12, 2025 08:18
@github-actions github-actions bot added this to the 1.0.1-alpha milestone Oct 12, 2025
@github-actions
Copy link
Contributor

🏷️ This PR has been automatically assigned to milestone 1.0.1-alpha based on the version in Solution.props.

@marc-romu marc-romu added the scope: Model Manager Issues related to the Model Manager label Oct 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the model capability validation system to be more permissive with unregistered AI models. Instead of rejecting unregistered models, the system now bypasses capability validation and assumes they support the required capabilities.

  • Changed validation logic to return true for unregistered models instead of false
  • Downgraded warning messages to info level for better user experience
  • Updated version and documentation to reflect the changes

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ModelManager.cs Core logic change to bypass validation for unregistered models
ToolCapabilityValidator.cs Minor formatting improvement with added blank line
AIRequestCall.cs Downgraded message severity from Warning to Info for unregistered models
Solution.props Version bump to 1.0.1-dev.251012
README.md Updated version badges and status information
CHANGELOG.md Added entry documenting the capability validation changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@marc-romu marc-romu linked an issue Oct 12, 2025 that may be closed by this pull request
@marc-romu marc-romu self-assigned this Oct 12, 2025
@marc-romu marc-romu merged commit eb706c0 into dev Oct 12, 2025
10 checks passed
@github-actions github-actions bot deleted the bugfix/1.0.1-model-validation-fix branch October 12, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: Model Manager Issues related to the Model Manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing error message on wrong model-provider combination

2 participants