Updates to latest eslint, mocha and leveldb #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianleroux
changed the title
macdonst
reviewed
Sep 17, 2025
macdonst
left a comment
macdonst
left a comment
There was a problem hiding this comment.
This looks good to me but I didn't run the code in an existing Architect app. It would be nice to get an RC out so we can try it.
Props on getting rid of leveldown. I noticed it added 20mb to the node_modules of an app I'm working on and it is not longer supported so it's great to see that it's gone.
Member
Author
install goes from 10s to .3s |
Member
Author
|
published. try out w |
Member
Author
also no mo weird warnings
|
Member
Author
|
built test rig to check out the RC and all seems legit https://github.com/architect/dynalite-test |
filmaj
approved these changes
Sep 17, 2025
Member
filmaj
left a comment
filmaj
left a comment
There was a problem hiding this comment.
Tested this out using package.json overrides in my beefy arc app, worked well locally, using complex DDB queries and additional GSIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to latest eslint, mocha and leveldb; this should probably be a semver MAJOR bump and think we'll also want to do an RC or two to make sure it doesn't regress