Merged
Conversation
In tor mode, the entrypoint didn't add announce-addr for the generated .onion address, so the node was undiscoverable. In hybrid mode, the announce-addr logic existed but had two bugs: 1. Temp Tor ran as root but /var/lib/tor/cln-service is owned by debian-tor, causing a permission error 2. Killing the su wrapper didn't kill the actual tor child process, leaving port 9050 bound when supervisor tried to start the main Tor Fixes: - Add onion announce-addr to tor mode (matching hybrid behavior) - Run temp Tor as debian-tor via su - Use pkill to kill the actual tor process after hostname generation - Poll for port 9050 release before handing off to supervisor Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tormode, addannounce-addrfor the generated.onionaddress so the node is discoverable (was only done inhybridmode)debian-torto fix permission error on/var/lib/tor/cln-servicepkillto kill the actual tor process (not just thesuwrapper) after hostname generationAlso upstream: lightning-goats#81
Test plan
getinfoshows.onionaddress in theaddressarray🤖 Generated with Claude Code