-
Notifications
You must be signed in to change notification settings - Fork 13
Escape whole app state, as keys are also vulnerable to XSS injection #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tabazevedo
wants to merge
1
commit into
master
Choose a base branch
from
further-xss-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,124 +1,31 @@ | ||
| (function(){ | ||
| var xssFilters, jade, path, prelude, map, __template, escapeFilter; | ||
| var xssFilters, jade, path, prelude, map, __template; | ||
| xssFilters = require('xss-filters'); | ||
| jade = require('jade'); | ||
| path = require('path'); | ||
| prelude = require('prelude-ls'); | ||
| map = prelude.Obj.map; | ||
| __template = jade.compileFile(path.join(__dirname, 'index.jade')); | ||
| exports.escapeState = function(it){ | ||
| return xssFilters.inHTMLData(it); | ||
| }; | ||
| escapeFilter = function(k, v){ | ||
| if (deepEq$(typeof v, 'string', '===')) { | ||
| return exports.escapeState(v); | ||
| } else { | ||
| return v; | ||
| } | ||
| }; | ||
| exports.stringifyState = function(it){ | ||
| return JSON.stringify(it, escapeFilter); | ||
| return xssFilters.inHTMLData( | ||
| JSON.stringify( | ||
| it)); | ||
| }; | ||
| exports.renderBody = function(meta, body, appState, options){ | ||
| var stringifyState, bundlePath, archBody, layout, title; | ||
| stringifyState = exports.stringifyState; | ||
| var bundlePath, archBody, layout, title; | ||
| bundlePath = options.environment === 'development' | ||
| ? "http://localhost:3001/app.js" | ||
| : "/" + options.paths['public'] + "/app.js"; | ||
| archBody = __template({ | ||
| 'public': options.paths['public'], | ||
| bundle: bundlePath, | ||
| body: body, | ||
| state: stringifyState(appState) | ||
| state: exports.stringifyState(appState) | ||
| }); | ||
| layout = meta.layout, title = meta.title; | ||
| return layout({ | ||
| body: archBody, | ||
| title: title | ||
| }); | ||
| }; | ||
| function deepEq$(x, y, type){ | ||
| var toString = {}.toString, hasOwnProperty = {}.hasOwnProperty, | ||
| has = function (obj, key) { return hasOwnProperty.call(obj, key); }; | ||
| var first = true; | ||
| return eq(x, y, []); | ||
| function eq(a, b, stack) { | ||
| var className, length, size, result, alength, blength, r, key, ref, sizeB; | ||
| if (a == null || b == null) { return a === b; } | ||
| if (a.__placeholder__ || b.__placeholder__) { return true; } | ||
| if (a === b) { return a !== 0 || 1 / a == 1 / b; } | ||
| className = toString.call(a); | ||
| if (toString.call(b) != className) { return false; } | ||
| switch (className) { | ||
| case '[object String]': return a == String(b); | ||
| case '[object Number]': | ||
| return a != +a ? b != +b : (a == 0 ? 1 / a == 1 / b : a == +b); | ||
| case '[object Date]': | ||
| case '[object Boolean]': | ||
| return +a == +b; | ||
| case '[object RegExp]': | ||
| return a.source == b.source && | ||
| a.global == b.global && | ||
| a.multiline == b.multiline && | ||
| a.ignoreCase == b.ignoreCase; | ||
| } | ||
| if (typeof a != 'object' || typeof b != 'object') { return false; } | ||
| length = stack.length; | ||
| while (length--) { if (stack[length] == a) { return true; } } | ||
| stack.push(a); | ||
| size = 0; | ||
| result = true; | ||
| if (className == '[object Array]') { | ||
| alength = a.length; | ||
| blength = b.length; | ||
| if (first) { | ||
| switch (type) { | ||
| case '===': result = alength === blength; break; | ||
| case '<==': result = alength <= blength; break; | ||
| case '<<=': result = alength < blength; break; | ||
| } | ||
| size = alength; | ||
| first = false; | ||
| } else { | ||
| result = alength === blength; | ||
| size = alength; | ||
| } | ||
| if (result) { | ||
| while (size--) { | ||
| if (!(result = size in a == size in b && eq(a[size], b[size], stack))){ break; } | ||
| } | ||
| } | ||
| } else { | ||
| if ('constructor' in a != 'constructor' in b || a.constructor != b.constructor) { | ||
| return false; | ||
| } | ||
| for (key in a) { | ||
| if (has(a, key)) { | ||
| size++; | ||
| if (!(result = has(b, key) && eq(a[key], b[key], stack))) { break; } | ||
| } | ||
| } | ||
| if (result) { | ||
| sizeB = 0; | ||
| for (key in b) { | ||
| if (has(b, key)) { ++sizeB; } | ||
| } | ||
| if (first) { | ||
| if (type === '<<=') { | ||
| result = size < sizeB; | ||
| } else if (type === '<==') { | ||
| result = size <= sizeB | ||
| } else { | ||
| result = size === sizeB; | ||
| } | ||
| } else { | ||
| first = false; | ||
| result = size === sizeB; | ||
| } | ||
| } | ||
| } | ||
| stack.pop(); | ||
| return result; | ||
| } | ||
| } | ||
| }).call(this); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I reading it right that this is
exports.just for tests? Can we not move that function, and possibly even the pipeline inapplication.ls(wrapped in a function) to it's own module? Something likesrc/state-serialisation.lsor similar.