fix: match note name without quotes #254
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna328p
requested changes
Oct 2, 2023
Collaborator
anna328p
left a comment
anna328p
left a comment
There was a problem hiding this comment.
matches on invalid inputs
"foo "bar" baz => name: foo "bar, text: baz
'foo'bar' baz => name: foo'bar, text: baz
'foo'bar baz => name: 'foo'bar, text: baz
fails to capture multiline text
"foo" bar
baz
=> name: foo, text: bar
Contributor
Author
|
The updated version passes your provided examples: For the original test notes, it behaves the same, with the exception of the |
anna328p
force-pushed
the
main
branch
2 times, most recently
from
65a2c2d to
0341574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some testing of the modified regexp and as you can see it works fine