Skip to content

Porting finish-workflow-without-run#946

Merged
itutu-tienday merged 3 commits intodevelop-mainfrom
feature/porting_finish_workflow_without_run
Oct 8, 2025
Merged

Porting finish-workflow-without-run#946
itutu-tienday merged 3 commits intodevelop-mainfrom
feature/porting_finish_workflow_without_run

Conversation

@itutu-tienday
Copy link
Copy Markdown
Collaborator

@itutu-tienday itutu-tienday commented Oct 8, 2025

Content

Added a feature to instantly save workflow configuration (.yaml) without actually running Snakemake.

Feature

  • Added an immediate workflow save function (WorkflowRunner.finish_workflow_without_run)
  • Adjusted the display of immediately saved workflow records
    • Disabled the display link for Outputs
      • Workflow Screen: image
      • Visualize Screen: image

Testcase

  • At the time of writing this PR, this process (WorkflowRunner.finish_workflow_without_run) is not called anywhere, so testing is not necessary.

    • Test code covers this
      • studio/tests/app/common/core/workflow/test_workflow_runner.py
  • You can test the actual operation by applying the following code modifications:

    1. Replace the WorkflowRunner.run_workflow call in async def run in studio/app/common/routers/run.py with WorkflowRunner.finish_workflow_without_run
    2. Reproduce the execution results of async def run from the Record screen and check the displayed content.

itutu-tienday added 3 commits October 8, 2025 15:31
- Add OutputType.EMPTY to both frontend and backend
- Add OutputType.EMPTY to both frontend and backend
Copy link
Copy Markdown
Collaborator

@milesAraya milesAraya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hopefully we can add the frontend to save the workflows at some point soon

@itutu-tienday itutu-tienday merged commit f968faa into develop-main Oct 8, 2025
5 checks passed
@itutu-tienday itutu-tienday added the enhancement New feature or request label Oct 27, 2025
@itutu-tienday itutu-tienday deleted the feature/porting_finish_workflow_without_run branch January 19, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants