Skip to content

Add styled-components-ssr example#155

Open
madebynoam wants to merge 2 commits intoaranja:masterfrom
madebynoam:styled-components-ssr-example
Open

Add styled-components-ssr example#155
madebynoam wants to merge 2 commits intoaranja:masterfrom
madebynoam:styled-components-ssr-example

Conversation

@madebynoam
Copy link
Copy Markdown

Created a styled-components-ssr example for future reference.

It includes a styled-components middleware for Tux.

@eirikurn
Copy link
Copy Markdown
Member

eirikurn commented Jul 4, 2018 via email

@madebynoam
Copy link
Copy Markdown
Author

Thanks! Makes sense - I'll look into the addons next.

…his middleware.

Todo: Figure out the best way to test this middleware and best way to test styled components in general.
@madebynoam
Copy link
Copy Markdown
Author

Just committed the addon. The example now uses it as well.
The remaining task is to figure out a good way to write a test for this addon and styled components, any thoughts?

Copy link
Copy Markdown
Member

@eirikurn eirikurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

Fix the minor issues. Otherwise LGTM.

Would be great to get a basic README.md, can work from the react-router addon readme, but happy to get your input on documentation.

},
"peerDependencies": {
"react": ">16.0.0-beta",
"react-chain": "^0.5.0"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need peer dependency for styled-components. Actually does not depend on react.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also has a dependency on @neutrinojs/compile-loader and peer dependency on neutrino.

yarn.lock
yarn-error.log
yarn.lock
yarn.lock
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate ignore entries.

.DS_Store should arguably be in your global gitignore.

@madebynoam
Copy link
Copy Markdown
Author

Thanks! I'll be making the edits. Agree about the README.md, I'll work on it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants