Skip to content

ACL: revert if attempting to save empty params #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sohkai wants to merge 3 commits into
base: next
Choose a base branch
from
Open

ACL: revert if attempting to save empty params #499

sohkai wants to merge 3 commits into from

Conversation

@sohkai
Copy link
Contributor

@sohkai sohkai commented Mar 26, 2019 •
edited
Loading

0x290decd9548b62a8d60345a988386fc84ba6bc95484008f6362f93160ef3e563 is actually keccak256([0]), rather than keccak256([]). However, it looks like web3-utils@1.0.0-beta.33 doesn't really know the difference either :/

Screen Shot 2019-03-18 at 4 46 55 PM

@sohkai sohkai requested review from facuspagnuolo and izqui March 26, 2019 00:48
@coveralls
Copy link

coveralls commented Mar 26, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 99.542% when pulling c72ac63 on acl-revert-on-saving-empty-params into bef0141 on dev.

izqui
izqui approved these changes Mar 27, 2019
View reviewed changes
facuspagnuolo
facuspagnuolo approved these changes Mar 29, 2019
View reviewed changes
@sohkai sohkai force-pushed the acl-revert-on-saving-empty-params branch from ded7a42 to c72ac63 Compare April 9, 2019 17:33
@sohkai sohkai changed the base branch from dev to next July 11, 2019 09:28
@sohkai sohkai added this to the aragonOS 5.0 milestone Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@izqui izqui izqui approved these changes

@facuspagnuolo facuspagnuolo facuspagnuolo approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

component: acl

Projects

None yet

Milestone

aragonOS 5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@sohkai @coveralls @izqui @facuspagnuolo