Skip to content

Conversation

@ronso0
Copy link

@ronso0 ronso0 commented Aug 6, 2025

I collected some fixes.

First commits are small and self-explanatory, but for the last chunk I ran out of time and commited as a whole.
See commit message for details.

I didn't yet touch the m_oldRecSampleRate which is (I guess) not updated correctly and therefor giving me the UX issue I mentioned earlier.

@ar-in0
Copy link
Owner

ar-in0 commented Aug 28, 2025

Sorry for the late response - took a break from Mixxx for a few weeks. I just built this PR.
this-gui-pr1

GUI in this PR (above) needs to be fixed.

correct-gui-15081

The above GUI is the target (current state of mixxxdj#15081)

It appears the changes in this PR have undone some of the functionality (and previous fixes). oldrecsamplerate is not being updated correctly. This UX issue was resolved in 7bf99be, before the set of commits in this PR.

@ronso0 ronso0 force-pushed the issue#10611_record_broadcast_libsamplerate branch from 386a3ae to 811262a Compare September 27, 2025 19:30
@ronso0
Copy link
Author

ronso0 commented Sep 27, 2025

Oh, sorry for letting this sit so long!

I'm not into this anymore unfortunately.
I rebased and removed the complex refactoring, should now only be some cleanup and a tweak.
Please test.


However, there are still a few things that are either wrong, for example setting a fixed width on translatable buttons

    RadioButtonUseCustomSampleRate->setMaximumWidth(80);
    RadioButtonUseDefaultSampleRate->setMaximumWidth(234);

or can be improved

  • use mixxx::audio::SampleRate
  • remove excessive logging in preferences
  • catch [App],samplerate changes and update preferences accordingly
  • use helper to set text on RadioButtonUseDefaultSampleRate

Do you think you can take a look, or shall I? Won't happen soon, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants