Skip to content

ci: require release for docker image so that python version is available #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpopesculian merged 1 commit into from
Jan 10, 2026
Merged

ci: require release for docker image so that python version is available #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/cd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ jobs:
release:
name: Release
runs-on: ubuntu-latest
if: "startsWith(github.ref, 'refs/tags/')"
needs: [linux, windows, macos, sdist]
steps:
- uses: actions/download-artifact@v4
Expand All @@ -116,6 +115,7 @@ jobs:
merge-multiple: true
- name: Publish to PyPI
uses: PyO3/maturin-action@v1
if: "startsWith(github.ref, 'refs/tags/')"
env:
MATURIN_PYPI_TOKEN: ${{ secrets.PYPI_API_TOKEN }}
with:
Expand All @@ -125,6 +125,7 @@ jobs:
docker:
name: Build and Push Docker Image
runs-on: ubuntu-latest
needs: [release]
Copy link

@coderabbitai coderabbitai bot Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check docker-bake.hcl and Dockerfile for references to wheel artifacts or version info

echo "=== Checking docker-bake.hcl for artifact or version references ==="
if [ -f "docker-bake.hcl" ]; then
  cat docker-bake.hcl
else
  echo "docker-bake.hcl not found"
fi

echo -e "\n=== Searching for Dockerfiles that might reference wheels or version ==="
find . -name "Dockerfile*" -type f | head -20 | xargs -I {} sh -c 'echo "--- {} ---"; cat "{}"'

echo -e "\n=== Checking for any references to wheel files or maturin in docker context ==="
rg -n "\.whl|maturin|PYTHON_VERSION|pyproject" . --type docker || echo "No references found in docker files"

echo -e "\n=== Checking cd.yaml workflow structure around docker and release jobs ==="
sed -n '100,200p' .github/workflows/cd.yaml

Repository: aqora-io/cli

Length of output: 4844

🏁 Script executed:

#!/bin/bash
# Check if release job has any outputs defined

echo "=== Full release job definition in cd.yaml ==="
sed -n '/^  release:/,/^  [a-z]/p' .github/workflows/cd.yaml | head -50

echo -e "\n=== Check if docker job uses any outputs from release ==="
sed -n '/^  docker:/,/^  [a-z]/p' .github/workflows/cd.yaml | grep -i "release\|needs\|env\|output"

echo -e "\n=== Check git history for this change ==="
git log --oneline --all -n 20 | head -20

Repository: aqora-io/cli

Length of output: 1682

Remove the release job dependency or condition it on tag events only.

The docker job depends on the release job, which causes it to wait for all platform builds on every event (PRs, main pushes, tags). However:

  1. The docker build does not download or reference any artifacts from the release job
  2. The release job defines no outputs to pass to the docker job
  3. The Dockerfile compiles the Rust binary from source via cargo—it has no dependency on the wheel artifacts the release job publishes
  4. The docker metadata action generates tags purely from git refs, not from release job data

The commit message claims "python version is available" from this dependency, but no mechanism exists to pass any data between the jobs. On non-tag events, this dependency is wasteful because the release job doesn't publish anyway (if: "startsWith(github.ref, 'refs/tags/')" is conditional).

Either remove the dependency entirely, or condition it on tag events: if: startsWith(github.ref, 'refs/tags/').

🤖 Prompt for AI Agents 
In @.github/workflows/cd.yaml at line 128, The docker job currently lists a hard
dependency "needs: [release]" which causes unnecessary waiting on non-tag
events; either remove the needs entry from the docker job or make the dependency
conditional for tag events only by adding an if condition on the docker job (use
the existing tag check startsWith(github.ref, 'refs/tags/')). Update the docker
job definition that contains "needs: [release]" so it either drops that needs
array entirely or keeps it but adds the if: startsWith(github.ref, 'refs/tags/')
guard to ensure the release dependency is only required for tag-triggered runs.

permissions:
contents: read
packages: write
Expand Down Expand Up @@ -159,9 +160,7 @@ jobs:
files: |
./docker-bake.hcl
cwd://${{ steps.meta-kubimo.outputs.bake-file }}
# TODO: change before merging
# push: ${{ github.event_name != 'pull_request' }}
push: true
push: ${{ github.event_name != 'pull_request' }}

npm:
name: Build and publish npm package
Expand Down
2 changes: 1 addition & 1 deletion src/commands/new/dataset_marimo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ pub async fn dataset_marimo(args: DatasetMarimo, global: GlobalArgs) -> Result<(
.map_err(|e| format_permission_error("create dataset-marimo", &dest, &e))?;

pb.finish_with_message(format!(
"Created dataset marimo noteboook in '{}'",
"Created dataset marimo notebook in '{}'",
dest.display()
));
Ok(())
Expand Down
Loading