Draft
Conversation
- Add pnpm override for preact >=10.28.2 to fix high severity JSON VNode Injection vulnerability (GHSA-36hm-qxxp-pg3m) - Add missing rel="noopener noreferrer" to external links in PageFrame.astro and MoveReferenceDisabled.astro to prevent potential tabnapping attacks
Added pnpm overrides for lodash and lodash-es to force version 4.17.23, addressing the security vulnerability in older versions.
- Updated sidebar types to support 'link' property on groups - Modified groups to use 'link' pointing to overview pages instead of having separate overview items - Applied changes to: SDKs, APIs, Indexer, CLI, Guides, Smart Contracts, Nodes, Concepts, AI, and Reference sections - Fixed pre-existing TypeScript lint errors in sidebar.ts This improves navigation UX by making section headers directly clickable to access the overview page, reducing duplicate navigation items.
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Starlight v0.37.3 does not support having both 'link' and 'items' properties on sidebar groups. The sidebar schema treats these as mutually exclusive - an entry is either a link item OR a group item. This feature (clickable group headers with expandable children) would require changes to Starlight's sidebar schema or a custom component override. Reverting to the original sidebar structure where overview pages remain as separate items within their groups. Note: Kept TypeScript lint fixes for src/config/sidebar.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate sidebar landing pages with their section headers to improve navigation and reduce clutter.
Previously, overview pages for sections (e.g., "SDKs Overview") were separate items within their respective groups. This change makes the group header itself (e.g., "SDKs") clickable, directly leading to the overview page, thus removing the redundant entry and streamlining the sidebar structure. This required updating the sidebar type definitions to allow group headers to have a
linkproperty.Slack Thread