Skip to content

Conversation

@neolynx
Copy link
Member

@neolynx neolynx commented Jan 3, 2026

Coverage for #1518

https://wiki.debian.org/DebianRepository/Format#Signed-By says:
> **Signed-By**
> An optional field containing a comma separated list of
> OpenPGP key fingerprints to be used for validating
> the next Release file. The fingerprints must consist
> only of hex digits and may not contain spaces.
> The fingerprint specifies either the key the Release file
> must be signed with or the key the signature key must be
> a subkey of. The later match can be disabled by appending
> an exclamation mark to the fingerprint.
>
> If the field is present, a client should only accept future updates
> to the repository that are signed with keys listed in the field.
> The field should be ignored if the Valid-Until field is not present
> or if it is expired.

For both the CLI tools and JSON, the field is taken as a string verbatim.

When specified, we must also provide `Valid-Until` field,
and i'm not sure there is an 'infinity' value for it,
so 100 years will have to do?

Fixes #1497
@neolynx neolynx marked this pull request as draft January 3, 2026 22:42
@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

❌ Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.90%. Comparing base (836d9f3) to head (a4cc921).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
api/publish.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1519      +/-   ##
==========================================
+ Coverage   74.87%   74.90%   +0.03%     
==========================================
  Files         160      160              
  Lines       18518    18555      +37     
==========================================
+ Hits        13865    13899      +34     
- Misses       3502     3504       +2     
- Partials     1151     1152       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@neolynx neolynx merged commit ea797f8 into master Jan 4, 2026
80 checks passed
@neolynx neolynx deleted the inrelease-signedby branch January 4, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants