Skip to content

Conversation

@alguimodd
Copy link
Contributor

Fixes #1475

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

This adds the publishedPrefix to paths added to pathCache so it can be correctly compared to the relPath.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@neolynx neolynx self-assigned this Aug 15, 2025
@neolynx neolynx requested a review from cfiehe August 15, 2025 18:24
@neolynx neolynx added this to the 1.6.3 milestone Aug 27, 2025
@neolynx neolynx requested a review from a team August 29, 2025 08:36
@neolynx neolynx added needs review Ready for review & merge needs rebase The PR needs to be rebased on master labels Aug 30, 2025
Copy link
Contributor

@cfiehe cfiehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should fix the cache lookup issue. Files are looked up with respect to the publishedPrefix, but they are not put into the cache containing that publishedPrefix. The result is a cache miss in use cases with a non-empty publishedPrefix.

@alguimodd
Thanks yor fixing and your detailed analysis.

@neolynx
Can you please merge this change and close the corresponding issue. Thanks a lot.

@neolynx neolynx removed needs review Ready for review & merge needs rebase The PR needs to be rebased on master labels Nov 11, 2025
@neolynx neolynx merged commit ba65daf into aptly-dev:master Nov 11, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S3 uploads all packages whether they are already present or not in published mirror

3 participants