With aptible login --sso, open browser for token. #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user runs `aptible login --sso` with no token provided, we need to prompt them for the token. And users will need to go to the cli-sso-token page, so we may as well send them directly to the right page. This matches the behavior of similar commands like `aws sso login` from the AWS CLI, which opens a browser window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user runs
aptible login --ssowith no token provided, we needto prompt them for the token. And since users will need to go to the
cli-sso-token page, we may as well send them directly to the right
page.
This matches the behavior of similar commands like
aws sso loginfromthe AWS CLI, which opens a browser window.