Skip to content

Conversation

@DebakelOrakel
Copy link
Contributor

@DebakelOrakel DebakelOrakel commented May 2, 2025

This replaces the namespace label patch with an espejote patch.

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@github-actions
Copy link

github-actions bot commented May 2, 2025

🚀 This PR has been released as v1.6.1

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:patch

@DebakelOrakel DebakelOrakel force-pushed the change/use-espejote branch 2 times, most recently from 78ed31d to da95201 Compare May 7, 2025 14:15
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe switch to more recent component-espejote and make use of the auto-generated RBAC with esp.createContextRBAC()

This replaces the namespace label patch with an espejote patch.
@DebakelOrakel DebakelOrakel force-pushed the change/use-espejote branch from da95201 to 8788bda Compare May 7, 2025 14:46
@DebakelOrakel
Copy link
Contributor Author

maybe switch to more recent component-espejote and make use of the auto-generated RBAC with esp.createContextRBAC()

Oh nice 👍

@DebakelOrakel
Copy link
Contributor Author

Well, in this simple case it doesn't make much sense:

     verbs:
-      - '*'
+      - get
+      - list
+      - watch

I'll need additional Roles anyway.

@bastjan
Copy link
Member

bastjan commented May 7, 2025

I'll need additional Roles anyway.

We probbly could add an additional key _additionalVerbs: for the context and trigger sections for this use case.

@DebakelOrakel DebakelOrakel merged commit 8dfc8a7 into master May 7, 2025
17 checks passed
@DebakelOrakel DebakelOrakel deleted the change/use-espejote branch May 7, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants