Remove unused code #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detected using [vulture]: ``` $ vulture . --exclude __pypackages__,.venv onetimepass/db/models.py:67: unused variable 'OTPParams' (60% confidence) onetimepass/db/models.py:81: unused function 'valid_base32_secret' (60% confidence) onetimepass/db/models.py:89: unused function 'valid_params_for_otp_type' (60% confidence) onetimepass/db/models.py:106: unused function 'supported_version' (60% confidence) onetimepass/db/models.py:119: unused method 'add_totp_alias' (60% confidence) onetimepass/db/models.py:159: unused function 'get_params_by_type' (60% confidence) onetimepass/enum.py:12: unused method '_missing_' (60% confidence) onetimepass/enum.py:27: unused variable 'SHA256' (60% confidence) onetimepass/enum.py:28: unused variable 'SHA512' (60% confidence) onetimepass/otp.py:146: unused function 'show' (60% confidence) onetimepass/otp.py:220: unused function 'init' (60% confidence) onetimepass/otp.py:261: unused function 'delete' (60% confidence) onetimepass/otp.py:281: unused function 'list_' (60% confidence) onetimepass/otp.py:302: unused function 'export' (60% confidence) onetimepass/otp.py:316: unused function 'import_' (60% confidence) onetimepass/otp.py:351: unused function 'add_uri' (60% confidence) onetimepass/otp.py:427: unused function 'add_hotp' (60% confidence) onetimepass/otp.py:479: unused function 'add_totp' (60% confidence) onetimepass/otp.py:539: unused function 'rename' (60% confidence) onetimepass/otpauth/errors.py:10: unused variable 'msg_template' (60% confidence) onetimepass/otpauth/errors.py:18: unused variable 'msg_template' (60% confidence) onetimepass/otpauth/errors.py:23: unused variable 'msg_template' (60% confidence) onetimepass/otpauth/schemas.py:24: unused function 'issuer_must_match_pattern' (60% confidence) onetimepass/otpauth/schemas.py:109: unused function 'strip_leading_spaces' (60% confidence) onetimepass/otpauth/schemas.py:125: unused function 'scheme_must_be_otpauth' (60% confidence) onetimepass/otpauth/schemas.py:131: unused function 'set_label' (60% confidence) onetimepass/otpauth/schemas.py:135: unused function 'parameters_issuer_equals_label_issuer' (60% confidence) onetimepass/settings.py:12: unused variable 'DEFAULT_HASH_ALGORITHM' (60% confidence) ``` Some of those were false positives: most notably, `@validator`-decorated functions in Pydantic models and `@click.*`-decorated functions that implement the bottom-most commands. [vulture]: https://github.com/jendrikseipp/vulture/tree/v2.11
The detector of an unused code. See: https://github.com/jendrikseipp/vulture/tree/v2.11
Toreno96
force-pushed
the
remove-unused-code
branch
from
0c71bb8 to
a653576
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.