Closed
Conversation
Co-authored-by: governer <governer@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Owner
Author
|
merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align autopilot NMEA sentence generation with Avare by standardizing units, correcting cross-track deviation, and improving RMB/BOD emission logic.
The previous implementation of
AutoPilot.apCreateSentenceshad several discrepancies compared to the Avare reference. Specifically, speed and distance units in$GPRMCand$GPRMBwere tied to user display settings instead of always being knots/NM, the cross-track deviation calculation in$GPRMBincorrectly used degrees withsin(), and$GPRMB/$GPBODsentences were not generated for the first leg of a flight plan. This PR addresses these inconsistencies to ensure more accurate and consistent NMEA output.