Closed
Conversation
Co-authored-by: governer <governer@gmail.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes KML tracks file being empty by correcting the logic for resetting and saving tracks when the layer opacity slider changes.
The previous implementation would reset
Storage().tracks(clearing recorded points) on any non-zero slider change, including when dragging the slider towards zero. This caused the tracks to be cleared beforesaveKml()could execute, resulting in an empty KML file. The fix ensures tracks are only reset when the layer is turned on (0 -> >0 opacity) and saved when the layer is turned off (>0 -> 0 opacity).