Add rotate button to Plates. Closes #245.#417
Open
jackwilliard wants to merge 3 commits intoapps4av:masterfrom
Open
Add rotate button to Plates. Closes #245.#417jackwilliard wants to merge 3 commits intoapps4av:masterfrom
jackwilliard wants to merge 3 commits intoapps4av:masterfrom
Conversation
Adds a rotate button to the airport diagrams and approach plates. This button does not appear in Track Up mode. Each click of the button rotates the diagram 90 degrees clockwise. Four files are affected within the UI code.
Adds a rotate button to the airport diagrams and approach plates. This button does not appear in Track Up mode. Each click of the button rotates the diagram 90 degrees clockwise. Four files are affected within the UI code. Change removes rotation when plate changes.
Adds a rotate button to the airport diagrams and approach plates. This button does not appear in Track Up mode. Updated to allow arbitrary rotation of plate to 10 degree alignments while handling the most common case of 90degree rotations.
Owner
|
10 degree rotation is very confusing. |
Owner
|
To reduce clicks, suggest having a button that shows "rotate" |
Contributor
Author
|
Yes, that is how pull request bbbb816 worked. It got kicked back without much explanation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #245. Adds a rotate button to the airport diagrams and approach plates. This button does not appear in Track Up mode.
Each click of the button rotates the diagram 90 degrees clockwise.
Four files are affected within the UI code.