Improved parsing of APT.txt to use ICAO codes.#317
Open
johnpayne wants to merge 1 commit intoapps4av:masterfrom
Open
Improved parsing of APT.txt to use ICAO codes.#317johnpayne wants to merge 1 commit intoapps4av:masterfrom
johnpayne wants to merge 1 commit intoapps4av:masterfrom
Conversation
Owner
|
Nice. Is that tested to make sure only Alaska is affected? Also need to test ADD, airport diagrams, plate minimums and Internet downloaded weather. |
Author
|
No, it is not tested. I have been struggling to get my local environment
working for testing.
I don't even know if the data this script is parsing is the same data that
is used in the "find" function.
I've tried running a clean build, but it still doesn't seem to be finding
airports in alaska with ICAO identifiers even after my code change.
Does APT.txt end up being used as data for the "Find" page? Or does that
come from some other dataset?
…On Sat, Oct 14, 2017 at 1:58 PM, Apps4Av ***@***.***> wrote:
Nice. Is that tested to make sure only Alaska is affected? Also need to
test ADD, airport diagrams, plate minimums and Internet downloaded weather.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#317 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADBBy2Gmkwd1ABJoUuH7k47fZSKMqtGzks5ssS6RgaJpZM4P5R8B>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do you think of this change? It tries to use the ICAO code first, else defaults to the IATA code listed. This is an attempt to get Alaska airports searchable by ICAO codes, not just IATA 3 letter codes.