Naming GPS waypoints in ->Destination and ->Plan form#224
Open
pasniak wants to merge 5 commits intoapps4av:masterfrom
Open
Naming GPS waypoints in ->Destination and ->Plan form#224pasniak wants to merge 5 commits intoapps4av:masterfrom
pasniak wants to merge 5 commits intoapps4av:masterfrom
Conversation
added 5 commits
October 4, 2016 05:22
…ws the name@lat&lon convention; the WebApMapInterface returns with action`newName string (before: only action is returned)
…ws the name@lat&lon convention
…ws the name@lat&lon convention; the WebApMapInterface returns with action`newName string (before: only action is returned)
…ws the name@lat&lon convention
Conflicts: app/src/main/assets/map.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having named waypoints in a Plan is a prerequisite for emitting meaningful en-route notifications for GPS-type waypoints.
The change also adds ability to rename GPS-type waypoints after they are created albeit the "old" name is not displayed.