Skip to content

Allow to set number of retries, timeouts #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
okapusta wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow to set number of retries, timeouts #11

okapusta wants to merge 2 commits into from

Conversation

@okapusta
Copy link

@okapusta okapusta commented Sep 18, 2019 •
edited
Loading

FIxed tests, added ability to set number of retries & timeouts

danriti
danriti reviewed Sep 18, 2019
View reviewed changes
lib/appoptics/metrics/connection.rb

def retry_count
@retry_count || 3
end
Copy link

@danriti danriti Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

danriti
danriti reviewed Sep 18, 2019
View reviewed changes
danriti
danriti reviewed Sep 18, 2019
View reviewed changes
Copy link

@danriti danriti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okapusta the code changes look reasonable, however it looks like the build is failing?

@okapusta okapusta force-pushed the customize-timeouts-retries branch from c79354d to 3791caf Compare September 18, 2019 13:04
@okapusta
Copy link
Author

okapusta commented Sep 18, 2019

@danriti Build fails for JRuby. I will have a look

@okapusta
Copy link
Author

okapusta commented Sep 18, 2019

@danriti
Hm...

➜  appoptics-api-ruby git:(customize-timeouts-retries) be rake 
/Users/oskar.kapusta/.rbenv/versions/jruby-1.7.27/bin/jruby -I/Users/oskar.kapusta/.rbenv/versions/jruby-1.7.27/lib/ruby/gems/shared/gems/rspec-core-3.5.4/lib:/Users/oskar.kapusta/.rbenv/versions/jruby-1.7.27/lib/ruby/gems/shared/gems/rspec-support-3.5.0/lib /Users/oskar.kapusta/.rbenv/versions/jruby-1.7.27/lib/ruby/gems/shared/gems/rspec-core-3.5.4/exe/rspec --pattern spec/unit/\*\*/\*_spec.rb --color
...........................................................................................................................................

Finished in 18.55 seconds (files took 1.13 seconds to load)
139 examples, 0 failures

TEST_API_USER and TEST_API_KEY not in environment, skipping integration tests...
➜  appoptics-api-ruby git:(customize-timeouts-retries) ruby -v 
jruby 1.7.27 (1.9.3p551) 2017-05-11 8cdb01a on OpenJDK 64-Bit Server VM 1.8.0_212-b04 +jit [darwin-x86_64]
➜  appoptics-api-ruby git:(customize-timeouts-retries)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danriti danriti danriti left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@okapusta @danriti