HMOS Assignment: Day2 and Day3 - Kanishka Halder #42
Conversation
samuel-abhishek
left a comment
samuel-abhishek
left a comment
There was a problem hiding this comment.
Please handle the mentioned changes
| super.setUIContent(ResourceTable.Layout_ability_signup); | ||
| // "permissions": [ | ||
| // "com.applib.loginsignupapp.DataAbilityShellProvider.PROVIDER" | ||
| // ], |
There was a problem hiding this comment.
Delete the useless code. (Applies to all files)
| value.putString("password", password.getText()); | ||
| isAllValidated = password.isValidated() && isAllValidated; | ||
| } | ||
| RadioButton selectedButton = (RadioButton) findComponentById(radioContainer.getMarkedButtonId()); |
There was a problem hiding this comment.
This casting is dangerous!! It will lead to ClassCastException - when no radiobuttons are selected in the radioContainer and crash the application.[App crash scenario : Submit the form without selecting any of the radiobuttons. The app will crash]
| isAllValidated = lastName.isValidated() && isAllValidated; | ||
| } | ||
| if(emailId.getText()!=null) { | ||
| value.putString("email", emailId.getText()); |
There was a problem hiding this comment.
Avoid using hardcoded strings. Use constants instead. (Applies to all the files)
|
|
3 participants
No description provided.