HOS_assign #41
HOS_assign #41
Conversation
samuel-abhishek
left a comment
samuel-abhishek
left a comment
There was a problem hiding this comment.
Please test the app thoroughly with all possible user scenarios before commit
| ohos:below="$id:a" | ||
| ohos:orientation="horizontal" | ||
| > | ||
| <RadioButton |
There was a problem hiding this comment.
Incorrect way to use the radio button for this use case. This way of implementation will let you select both Male & Female. (Suggestion : Use RadioContainer to group the radio buttons)
There was a problem hiding this comment.
Implemented click listener in SignUp class to set other false if pressed
| TextField mobile = (TextField) findComponentById(ResourceTable.Id_mobile); | ||
| RadioButton male = (RadioButton) findComponentById(ResourceTable.Id_gender_male); | ||
| RadioButton female = (RadioButton) findComponentById(ResourceTable.Id_gender_female); | ||
|
|
There was a problem hiding this comment.
SignupButton validation is missing.. For the signup button, validate if all the above fields are entered properly.
There was a problem hiding this comment.
Added SignUp validation
| if (!name.matches("^[a-zA-Z]*$")) { | ||
| //firstname.setText(""); | ||
| Text er1 = (Text) findComponentById(ResourceTable.Id_er1); | ||
| er1.setVisibility(Component.VISIBLE); |
There was a problem hiding this comment.
"er1" must have a null check as setFocusChangedListener is being used.!! [App crash possible scenario : If user clicks on the textfield with setFocusChangedListener and then clicks back button. ] Make sure all the error fields in this class are having the null checks as they are inflated inside the focusChangedListener
| email.setFocusChangedListener((component, isFocused) -> { | ||
| String name = email.getText(); | ||
| if (!isFocused) { | ||
| if (!name.matches("^[a-zA-Z0-9+_.-]+@[a-zA-Z0-9.-]+$")) { |
There was a problem hiding this comment.
Do not use hardcoded string the code. Use Constants
| String name = firstname.getText(); | ||
| if (!isFocused) { | ||
| if (!name.matches("^[a-zA-Z]*$")) { | ||
| //firstname.setText(""); |
There was a problem hiding this comment.
Delete the useless code.(Applies to all files)
|
|
3 participants
Pull request for HOS assignment