day1 assignment #33
day1 assignment #33
Conversation
| public void onBindViewHolder(@NonNull ViewHolder holder, final int i) { | ||
| final ModelItems item = items.get(i); | ||
|
|
||
|
|
There was a problem hiding this comment.
Delete the unnecessary spaces. Applies to all files
| private ViewPager viewPager; | ||
| private MyPageAdapter adapter; | ||
| @Override | ||
| protected void onCreate(Bundle savedInstanceState) { |
There was a problem hiding this comment.
NavigationDrawer functionality is missing as per the problem statement. Please check. You can include the diff categories in NavigationDrawer instead of TabbedLayout
|
|
||
| @Override | ||
| public Fragment getItem(int i) { | ||
| // Log.e("pra"," "+i); |
There was a problem hiding this comment.
Delete the commented code. Applies to all files
| } | ||
|
|
||
|
|
||
| public void moveNext(View view) { |
There was a problem hiding this comment.
Need to hide the next button when you are in the last page of the view pager. Also, when user clicks on the next button in the last page of the viewpager, then the user must be taken out of the viewpager and can be directed to an empty activity,
| viewPager.setCurrentItem(2); | ||
| } | ||
|
|
||
| public void moveBack(View view){ |
There was a problem hiding this comment.
Need to hide the back button when you are in the first page of the view pager
| } | ||
|
|
||
| public void moveSkip(View view) { | ||
| viewPager.setCurrentItem(2); |
There was a problem hiding this comment.
Skip functionality is incorrect. OnClick of skip button must make the user skip the viewpager and display the first activity that will be displayed after clicking the Next button on the last page in the viewpager
| import android.os.Bundle; | ||
| import android.os.Handler; | ||
|
|
||
| public class SplashActivity extends Activity { |
There was a problem hiding this comment.
This activity is not required. The ViewPager is supposed to be the splash screen
| testImplementation 'junit:junit:4.+' | ||
| androidTestImplementation 'androidx.test.ext:junit:1.1.2' | ||
| androidTestImplementation 'androidx.test.espresso:espresso-core:3.3.0' | ||
| implementation 'com.journeyapps:zxing-android-embedded:4.1.0' |
There was a problem hiding this comment.
Please include a README file in the project and explain the purpose of usage of the lib
|
|
3 participants
No description provided.