Skip to content

Shrey Shrivastava Self Assessment #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shreyshrivastava4799 wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Shrey Shrivastava Self Assessment #19

shreyshrivastava4799 wants to merge 19 commits into from

Conversation

@shreyshrivastava4799
Copy link

@shreyshrivastava4799 shreyshrivastava4799 commented May 25, 2021

No description provided.

samuel-abhishek
samuel-abhishek suggested changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@samuel-abhishek samuel-abhishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No code is present for advanced app - NewsFeed. Please check & upload. Also, handle the mentioned changes in the review comments.

Android/shreyshrivastava/Intermediate/ToDo/app/src/main/java/com/example/todo/TaskAdapter.java

Context context;
List<TaskModel> taskModelList;
FirebaseFirestore db;
Copy link
Contributor

@samuel-abhishek samuel-abhishek Jun 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update task functionality is missed. Please handle. Suggest you to add an update button in the list item view and when user clicks on it - load the item in edit text and update the entry in DB after user clicks on ADD button to save the changes

Copy link
Author

@shreyshrivastava4799 shreyshrivastava4799 Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update functionality.

...eyshrivastava/Advanced/NewsFeed/app/build/intermediates/dex_number_of_buckets_file/debug/out Outdated
@@ -0,0 +1 @@
2 No newline at end of file
Copy link
Contributor

@samuel-abhishek samuel-abhishek Jun 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid uploading app/build files into the repository.

Copy link
Author

@shreyshrivastava4799 shreyshrivastava4799 Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sharathks84 sharathks84 Awaiting requested review from sharathks84

1 more reviewer

@samuel-abhishek samuel-abhishek samuel-abhishek requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shreyshrivastava4799 @CLAassistant @samuel-abhishek