feat: support for external signers in NIOSSHPrivateKey#220
Open
camunro wants to merge 2 commits intoapple:mainfrom
Open
feat: support for external signers in NIOSSHPrivateKey#220camunro wants to merge 2 commits intoapple:mainfrom
camunro wants to merge 2 commits intoapple:mainfrom
Conversation
Motivation: Enables hardware-backed authentication and remote identity protocols by allowing NIOSSHPrivateKey to delegate signing operations to external providers (e.g., Secure Enclave, TPM, or ssh-agent) without requiring raw private key material in memory. Modifications: - Defined NIOSSHExternalSigner protocol for delegated signing. - Added .external case to NIOSSHPrivateKey for all supported algorithms (Ed25519, P-256, P-384, P-521). - Added NIOSSHError.externalSignerFailure for better error propagation. - Updated documentation and added comprehensive tests for external signing logic. Result: NIOSSH now supports public-key authentication where the signing operation is handled by an external delegate, providing a foundational hook for ssh-agent and hardware security integrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for External Signers in NIOSSHPrivateKey
Motivation
This PR enables hardware-backed authentication and remote identity protocols by allowing NIOSSHPrivateKey to delegate signing operations to external providers (e.g., Secure Enclave, TPM, or ssh-agent) without requiring raw private key material to be loaded into memory.
This is a foundational architectural change that enables several high-level features for the Swift ecosystem:
Modifications
NIOSSHPrivateKeyEvolution: Added an .external(NIOSSHExternalSigner) case to NIOSSHPrivateKey for all supported algorithms:Result
NIOSSH now supports public-key authentication where the signing operation is handled by an external delegate. This provides the critical architectural hook required for modern identity-aware SSH implementations (like #189) on both Apple and Linux platforms.