Conversation
Removes the additional indirection used SVD parsing which caused additional allocations. Overall this has a minor affect on performance but the code is more clear about ownership.
Comment on lines
+32
to
+35
| case .parsing(var stack): | ||
| let node = XMLElement(name: name) | ||
| stack.append(node) | ||
| self = .parsing(stack: stack) |
Member
There was a problem hiding this comment.
This is cool – even though stack is a var here, it's the only reference to that array since self is consumed at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the additional indirection used SVD parsing which caused additional allocations. Overall this has a minor affect on performance but the code is more clear about ownership.