Fix handling of visibility with nested OptionGroups. #838
+64
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bob-wilson
force-pushed
the
nested-group-visibility
branch
from
0c2af69 to
100aeb0
Compare
Member
natecook1000
left a comment
natecook1000
left a comment
There was a problem hiding this comment.
Thanks for this fix, @bob-wilson! Just a note about the tests; otherwise, this looks great to merge.
Comment on lines
197
to
206
| @OptionGroup(visibility: .hidden) | ||
| var flagsAndOptions: FlagsAndOptions | ||
|
|
||
| @OptionGroup(visibility: .private) | ||
| var argsAndFlags: ArgsAndFlags | ||
| @OptionGroup() | ||
| var nested: NestedGroups |
Member
There was a problem hiding this comment.
I think for completeness it would be best to keep this existing type and add a new NestedHiddenGroups/testNestedHiddenGroups() type/test function pair.
Contributor
Author
There was a problem hiding this comment.
OK, sure. I changed it as you suggested.
The visibility of OptionGroups is ignored if they are nested inside another OptionGroup. Instead of trying to filter groups when creating an ArgumentSet, use the OptionGroup's visibility to modify the arguments within the group.
bob-wilson
force-pushed
the
nested-group-visibility
branch
from
100aeb0 to
4315849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visibility of OptionGroups is ignored if they are nested inside another OptionGroup. Instead of trying to filter groups when creating an ArgumentSet, use the OptionGroup's visibility to modify the arguments within the group.
Checklist