Skip to content

Fix inference crash and dark rendering output #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nandometzger wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix inference crash and dark rendering output #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a95104a
Fix inference crash and dark rendering output
nandometzger Dec 18, 2025
6baa241
clean
nandometzger Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/sharp/utils/gaussians.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,14 +320,15 @@ def load_ply(path: Path) -> tuple[Gaussians3D, SceneMetaData]:
# Parse color space.
color_space_index = supplement_data.get("color_space", 1)
color_space = cs_utils.decode_color_space(color_space_index)
colors = torch.from_numpy(colors).view(1, -1, 3).float()

if color_space == "sRGB":
colors = cs_utils.sRGB2linearRGB(colors)

mean_vectors = torch.from_numpy(mean_vectors).view(1, -1, 3).float()
quaternions = torch.from_numpy(quaternions).view(1, -1, 4).float()
singular_values = torch.exp(torch.from_numpy(scale_logits).view(1, -1, 3)).float()
opacities = torch.sigmoid(torch.from_numpy(opacity_logits).view(1, -1)).float()
colors = torch.from_numpy(colors).view(1, -1, 3).float()

gaussians = Gaussians3D(
mean_vectors=mean_vectors,
Expand Down
2 changes: 1 addition & 1 deletion src/sharp/utils/gsplat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def forward(

# Colorspace conversion.
if self.color_space == "sRGB":
pass
rendered_color = cs_utils.linearRGB2sRGB(rendered_color)
Copy link

@domiverse domiverse Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thêm color render alias

elif self.color_space == "linearRGB":
rendered_color = cs_utils.linearRGB2sRGB(rendered_color)
else:
Expand Down