Skip to content

fix popen thread safety#2

Open
pvouzis wants to merge 1 commit intoapple-oss-distributions:mainfrom
pvouzis:fix-popen-thread-safety
Open

fix popen thread safety#2
pvouzis wants to merge 1 commit intoapple-oss-distributions:mainfrom
pvouzis:fix-popen-thread-safety

Conversation

@pvouzis
Copy link

@pvouzis pvouzis commented Apr 25, 2023

Lock is missing when parsing pidlist which can cause undefined behavior and a seg fault in multithread applications.

Added locks to fix the issue.

@wAuner
Copy link

wAuner commented Sep 14, 2023

Hey Panos, did you file a bug report with Apple via the Feedback Assistant? This PR will probably never be merged here.

@pvouzis
Copy link
Author

pvouzis commented Sep 14, 2023

Hi @wAuner I had this discussion https://developer.apple.com/forums/thread/726713 and I also wrote this: https://netbeez.net/blog/an-11-year-old-bug-in-the-macos-popen/

If there is a better way to get their attention lmk.

@wAuner
Copy link

wAuner commented Sep 15, 2023

I'm afraid there's probably nothing more that you could do. It's up to Apple now to fix this. I asked Quinn in your thread about the status.
How did you proceed to work around this issue? Did you replace the popen calls or used any of the other implementations you mentioned?

@pvouzis
Copy link
Author

pvouzis commented Sep 15, 2023

I got the current copy of popen(), I fixed the issue and I used it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants