Conversation
KazuCocoa
left a comment
KazuCocoa
left a comment
There was a problem hiding this comment.
left a comment, otherwise lgtm
lib/commands/actions.js
Outdated
| * @param {number|string} value - Number to set as the sensor value. | ||
| * @throws {Error} - If deviceType is not an emulator | ||
| */ | ||
| commands.sensorSet = async function sensorSet (sensorType, value) { |
There was a problem hiding this comment.
which external API endpoint is supposed to trigger this method?
There was a problem hiding this comment.
@mykola-mokhnach this is something I want to discuss with the community. We have two options here;
- using one endpoint per type of sensor. For ex; W3C already has a method for light sensor in progress. https://www.w3.org/TR/ambient-light/
- using one endpoint for all sensors.
I'd like to hear you guys feedback. I'll probably start the conversation later today in slack
There was a problem hiding this comment.
I would say it is always safe to have a "mobile:" endpoint for such purpose
There was a problem hiding this comment.
Added a new mapping here: https://github.com/appium/appium-android-driver/pull/555/files#diff-2ac213fe13b12323b4767dd0bd037ee4R37
|
We should require |
|
LGTM. Do not forget to add the same mobile command to uia2 and espresso after this PR is published |
3 participants
Prepare Android driver to support sensors set for Emulators implemented on ADB
appium/appium-adb#456