Skip to content

Conversation

@ihor-kravchenko-evinced

Summary

This PR introduces support for exposing accessibility custom actions as an element attribute using private XCTest APIs.

Motivation

Once this is in place:

  • Custom actions become visible in the element tree.
  • Clients like Appium (or other accessibility tools) can read them and make further validations or conclusions.
  • Accessibility regressions related to custom actions become detectable.

Implementation Notes

  • The value is retrieved using private attribute _XC_kAXXCAttributeCustomActions

These changes are additive, so they do not change existing behaviour.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 20, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@mykola-mokhnach
Copy link

The PR looks ok

Please also add some integration tests to cover the new functionality for page source generation and element attributes fetching. Also, do not forget to update the element double declaration in unit tests

@ihor-kravchenko-evinced ihor-kravchenko-evinced force-pushed the feat/add-cutom-custom-actions-attribute branch from 400c791 to 6fbf62e Compare December 20, 2025 12:25
@ihor-kravchenko-evinced ihor-kravchenko-evinced changed the title Add support for custom accessibility actions feat: expose customActions on the element Dec 25, 2025
@ihor-kravchenko-evinced ihor-kravchenko-evinced force-pushed the feat/add-cutom-custom-actions-attribute branch from ded5241 to ab036df Compare December 25, 2025 12:41
Add support for exposing custom accessibility actions from UI elements.
@ihor-kravchenko-evinced ihor-kravchenko-evinced force-pushed the feat/add-cutom-custom-actions-attribute branch from ab036df to f9518ed Compare December 25, 2025 13:09
@ihor-kravchenko-evinced ihor-kravchenko-evinced marked this pull request as ready for review December 25, 2025 13:11
@ihor-kravchenko-evinced
Copy link
Author

The PR looks ok

Please also add some integration tests to cover the new functionality for page source generation and element attributes fetching. Also, do not forget to update the element double declaration in unit tests

@mykola-mokhnach thank you for the feedback. I've added tests for page source generation and element attributes fetching.

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code lgtm entirely. lets wait for the CI result

@mykola-mokhnach mykola-mokhnach merged commit 3028512 into appium:master Dec 28, 2025
43 checks passed
@mykola-mokhnach
Copy link

Thank you for the PR @ihor-kravchenko-evinced

Please do not forget to create a follow up one in the xcuitest driver to document the newly added setting and element properties

github-actions bot pushed a commit that referenced this pull request Dec 28, 2025
## [11.1.0](v11.0.2...v11.1.0) (2025-12-28)

### Features

* expose customActions on the element ([#1095](#1095)) ([3028512](3028512))
@github-actions
Copy link

🎉 This PR is included in version 11.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KazuCocoa
Copy link
Member

Please add the settings' description in https://github.com/appium/appium-xcuitest-driver/blob/6761ee417c420ce2aa6ef0cfae42e84f6e9f2273/docs/reference/settings.md?plain=1#L49 🙏

@ihor-kravchenko-evinced
Copy link
Author

ihor-kravchenko-evinced commented Dec 29, 2025

@ihor-kravchenko-evinced
Copy link
Author

Thank you for the PR @ihor-kravchenko-evinced

Please do not forget to create a follow up one in the xcuitest driver to document the newly added setting and element properties

@mykola-mokhnach Added documentation here appium/appium-xcuitest-driver#2690.

@KazuCocoa KazuCocoa added the size:M contribution size: M label Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released size:M contribution size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants