-
Notifications
You must be signed in to change notification settings - Fork 463
feat: expose customActions on the element #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose customActions on the element #1095
Conversation
|
The PR looks ok Please also add some integration tests to cover the new functionality for page source generation and element attributes fetching. Also, do not forget to update the element double declaration in unit tests |
400c791 to
6fbf62e
Compare
ded5241 to
ab036df
Compare
Add support for exposing custom accessibility actions from UI elements.
ab036df to
f9518ed
Compare
@mykola-mokhnach thank you for the feedback. I've added tests for page source generation and element attributes fetching. |
KazuCocoa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code lgtm entirely. lets wait for the CI result
|
Thank you for the PR @ihor-kravchenko-evinced Please do not forget to create a follow up one in the xcuitest driver to document the newly added setting and element properties |
## [11.1.0](v11.0.2...v11.1.0) (2025-12-28) ### Features * expose customActions on the element ([#1095](#1095)) ([3028512](3028512))
|
🎉 This PR is included in version 11.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Please add the settings' description in https://github.com/appium/appium-xcuitest-driver/blob/6761ee417c420ce2aa6ef0cfae42e84f6e9f2273/docs/reference/settings.md?plain=1#L49 🙏 |
@KazuCocoa Added documentation here appium/appium-xcuitest-driver#2690. |
@mykola-mokhnach Added documentation here appium/appium-xcuitest-driver#2690. |
Summary
This PR introduces support for exposing accessibility custom actions as an element attribute using private XCTest APIs.
Motivation
Once this is in place:
Implementation Notes
_XC_kAXXCAttributeCustomActionsThese changes are additive, so they do not change existing behaviour.