Skip to content

fix: Address possible NULL binding compiler warning #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mykola-mokhnach merged 5 commits into from
Dec 18, 2025
Merged

fix: Address possible NULL binding compiler warning #1091

mykola-mokhnach merged 5 commits into from
Dec 18, 2025

Conversation

@mykola-mokhnach
Copy link

@mykola-mokhnach mykola-mokhnach commented Dec 18, 2025 

WebDriverAgent/WebDriverAgentLib/Vendor/CocoaAsyncSocket/GCDAsyncUdpSocket.m:3039:26: warning: The 2nd argument to 'bind' is NULL but should not be NULL [unix.StdCLibraryFunctions]
 3039 |             int status = bind(self->socket6FD, (const struct sockaddr *)[localAddr6 bytes], (socklen_t)[localAddr6 length]);
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

DanMPerfecto
DanMPerfecto approved these changes Dec 18, 2025
View reviewed changes
Copy link

@DanMPerfecto DanMPerfecto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to test it at the moment, but the logic looks good to me.

KazuCocoa
KazuCocoa approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

WebDriverAgentLib/Vendor/CocoaAsyncSocket/GCDAsyncUdpSocket.m Outdated
Comment on lines 3174 to 3176
self->flags |= kConnecting;

[self->sendQueue addObject:packet];
[self->sendQueue addObject:packet];
Copy link
Member

@KazuCocoa KazuCocoa Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe... these might need more spaces....? I guess this file has mixed with tabs/spaces...?

Copy link
Author

@mykola-mokhnach mykola-mokhnach Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to completely reformat the whole file in Xcode, but not in the same PR

@mykola-mokhnach mykola-mokhnach merged commit 263e646 into master Dec 18, 2025
46 of 47 checks passed
@mykola-mokhnach mykola-mokhnach deleted the comp262 branch December 18, 2025 16:56
github-actions bot pushed a commit that referenced this pull request Dec 18, 2025
@semantic-release-bot
chore(release): 10.5.2 [skip ci]
98c84cd 
## [10.5.2](v10.5.1...v10.5.2) (2025-12-18)

### Bug Fixes

* Address possible NULL binding compiler warning ([#1091](#1091)) ([263e646](263e646))
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

🎉 This PR is included in version 10.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

@Dan-Maor Dan-Maor Dan-Maor approved these changes

+1 more reviewer

@DanMPerfecto DanMPerfecto DanMPerfecto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mykola-mokhnach @KazuCocoa @Dan-Maor @DanMPerfecto