fix: properly handle GitHub Actions auto-skip in deployment job conditions #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
create_releasejob is skipped (e.g., onworkflow_dispatchwithskip_add_tag_and_release=true), GitHub Actions automatically skips all dependent jobs, even if they have customifconditions that should override this behavior. This prevents independent deployments from running when release creation is intentionally skipped.Root Cause
GitHub Actions has an implicit auto-skip mechanism: if a job depends on another job that is skipped, the dependent job is automatically skipped regardless of its
ifcondition. This is a safety feature to prevent dependent jobs from running in unexpected states, but it doesn't allow override via custom conditions alone.Solution
Add
!failure()status check function to the beginning of deployment job conditions. This explicitly tells GitHub Actions to evaluate the custom condition logic even when dependencies are skipped.How It Works
!failure()- Allows evaluation to proceed even if dependencies are skipped(github.event_name == 'workflow_dispatch' || needs.create_release.result == 'success')- Allows manual dispatch toBefore:
After:
Changes
deploy_pod_frameworkanddeploy_pod_frameworkjob condition${{ }}for clarity and to silence YAML linterTesting
You may use branch
michael/fix-cd-steps-rerunable-testfor testing and here is an execution record