Skip to content

Comments

Improve onExit command handler when exit command runs#169

Open
FelipeBarrosCruz wants to merge 2 commits intoapparatus:masterfrom
FelipeBarrosCruz:master
Open

Improve onExit command handler when exit command runs#169
FelipeBarrosCruz wants to merge 2 commits intoapparatus:masterfrom
FelipeBarrosCruz:master

Conversation

@FelipeBarrosCruz
Copy link

@FelipeBarrosCruz FelipeBarrosCruz commented Nov 13, 2017

onExit key on global schema is a shell script to execute like handler on exit command like docker-compose stop or anything you want to.

Pull request on fuge-config:
apparatus/fuge-config#11

fuge_global:
  tail: false
  monitor: false
  monitor_excludes:
    - '**/node_modules/**'
    - '**/.git/**'
    - '**/*.log'
  onExit:
    docker-compose -f docker-compose.yml stop;

@FelipeBarrosCruz FelipeBarrosCruz changed the title Improve onExit command handler when exit command run Improve onExit command handler when exit command runs Nov 13, 2017
@pelger
Copy link
Contributor

pelger commented Nov 13, 2017

Nice one - thanks! I think that this could be generally useful. Couple of things before merge please:

  • On fuge-config could you change the setting to be on_exit to be consistent with the rest of the config file.

  • On fuge-config could you add a unit test for this setting - this could be just an update to an existing fixture just to ensure it is passed through correctly

  • on this repo (fuge) could you add a unit test for on_exit

Let me know if you need any help doing this! Will merge once these are in.
Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants