Skip to content

Refactor some code #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jorgengaldal wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Refactor some code #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1dd2b02
refactor: reduce two ifs to if-else
jorgengaldal Feb 1, 2026
78f7c1b
same again
jorgengaldal Feb 1, 2026
237475b
same again for sms
jorgengaldal Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions lib/sendInterviewTimes/formatInterviewEmail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { formatDateHours } from "../utils/dateUtils";
import { changeDisplayName } from "../utils/toString";

export const formatApplicantInterviewEmail = (
applicant: emailApplicantInterviewType
applicant: emailApplicantInterviewType,
) => {
let emailBody = `<p>Hei <strong>${applicant.applicantName}</strong>,</p><p>Her er dine intervjutider for ${applicant.period_name}:</p><ul><br/>`;

Expand All @@ -20,18 +20,17 @@ export const formatApplicantInterviewEmail = (

applicant.committees.forEach((committee) => {
emailBody += `<li><b>Komité:</b> ${changeDisplayName(
committee.committeeName
committee.committeeName,
)}<br>`;

if (committee.interviewTime.start !== "Ikke satt") {
if (committee.interviewTime.start === "Ikke satt") {
emailBody += `<b>Tid:</b> Ikke satt. Komitéen vil ta kontakt med deg for å avtale tidspunkt.<br>`;
} else {
emailBody += `<b>Tid:</b> ${formatDateHours(
committee.interviewTime.start,
committee.interviewTime.end
committee.interviewTime.end,
)}<br>`;
}
if (committee.interviewTime.start === "Ikke satt") {
emailBody += `<b>Tid:</b> Ikke satt. Komitéen vil ta kontakt med deg for å avtale tidspunkt.<br>`;
}

emailBody += `<b>Rom:</b> ${committee.interviewTime.room}</li><br>`;
});
Expand All @@ -42,10 +41,10 @@ export const formatApplicantInterviewEmail = (
};

export const formatCommitteeInterviewEmail = (
committee: emailCommitteeInterviewType
committee: emailCommitteeInterviewType,
) => {
let emailBody = `<p>Hei <strong>${changeDisplayName(
committee.committeeName
committee.committeeName,
)}</strong>,</p><p>Her er deres intervjutider for ${
committee.applicants.length
} søkere:</p><ul>`;
Expand All @@ -61,16 +60,15 @@ export const formatCommitteeInterviewEmail = (
emailBody += `<li><b>Navn:</b> ${applicant.applicantName}<br>`;
emailBody += `<b>Telefon:</b> ${applicant.applicantPhone} <br> `;

if (applicant.interviewTime.start !== "Ikke satt") {
if (applicant.interviewTime.start === "Ikke satt") {
emailBody += `<b>Tid:</b> Ikke satt. Ta kontakt med søker for å avtale tidspunkt.`;
} else {
emailBody += `<b>Tid:</b> ${formatDateHours(
applicant.interviewTime.start,
applicant.interviewTime.end
applicant.interviewTime.end,
)}<br>`;
}

if (applicant.interviewTime.start === "Ikke satt") {
emailBody += `<b>Tid:</b> Ikke satt. Ta kontakt med søker for å avtale tidspunkt.`;
}
emailBody += `<b>Rom:</b> ${applicant.interviewTime.room}</li><br>`;
});

Expand Down
10 changes: 4 additions & 6 deletions lib/sendInterviewTimes/formatInterviewSMS.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,15 @@ export const formatInterviewSMS = (applicant: emailApplicantInterviewType) => {
applicant.committees.forEach((committee) => {
phoneBody += `Komité: ${changeDisplayName(committee.committeeName)} \n`;

if (committee.interviewTime.start !== "Ikke satt") {
if (committee.interviewTime.start === "Ikke satt") {
phoneBody += `Tid: Ikke satt. Komitéen vil ta kontakt for å avtale tidspunkt. \n`;
} else {
phoneBody += `Tid: ${formatDateHours(
committee.interviewTime.start,
committee.interviewTime.end
committee.interviewTime.end,
)}\n`;
}

if (committee.interviewTime.start === "Ikke satt") {
phoneBody += `Tid: Ikke satt. Komitéen vil ta kontakt for å avtale tidspunkt. \n`;
}

phoneBody += `Rom: ${committee.interviewTime.room} \n \n`;
});

Expand Down