This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Fixed current in pagination logic in BlogIndexPage.astro#6
Open
Tonel wants to merge 1 commit intoapostrophecms:mainfrom
Open
Fixed current in pagination logic in BlogIndexPage.astro#6Tonel wants to merge 1 commit intoapostrophecms:mainfrom
Tonel wants to merge 1 commit intoapostrophecms:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
BlogIndexPage.astro, there was the linepage === currentPage. The problem is thatpageis an object whilecurrentPageis a number, so that comparison was alwaysfalse.Now, it has been fixed.What are the specific steps to test this change?
What kind of change does this PR introduce?
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: