Open
Conversation
- Fixed paths to 3D models - Added connection pins
- Fixed library paths - Fixed 3D models paths - Fixed footprints
- Removed redundant traces - Fixed bad connections - Removed all Warnings
- rom-burner: Update libraries - rom-burner: Re-routed some paths to improve thermal reliefs in GND pads and avoid isolated islands - rom64kb: Re-routed some paths to avoid isolated islands - rom64kb: Removed solder mask in golden fingers area
Owner
|
First of all, apologies for my delayed response. I've been a few weeks off with little access to any computer. Secondly, many thanks for these updates and fixes! Just give me a break to find a time slot to check the changes and come back. |
Owner
|
I am having a look at your branch, and your changes bring tons of DRC violations: |
- Allow bridged solder mask apertures between pads - Redrawn mask zones
Author
Thanks for reviewing my changes! I've fixed the issues regarding the solder mask, redrawing the mask zones and enabling "Allow bridged solder mask apertures between pads" in the footprint solved the issue. |
Author
|
Hi @apoloval ! Did you have time to check the latest commits in this PR? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request updates the KiCAD designs of the rom-burner and the rom64kb cartridge to comply with the new symbol, model and footprint library paths and names standarized in KiCad 8, as well as applies some additional best practices, such as removing solder mask around golden fingers.
Changes