feat(skill): apollo-router-plugin-creator#30
feat(skill): apollo-router-plugin-creator#30samuelAndalon wants to merge 3 commits intoapollographql:mainfrom
Conversation
aaronArinder
left a comment
aaronArinder
left a comment
There was a problem hiding this comment.
thanks for adding this! it looks like a super interesting skill; I'm requesting changes as a formal block to have a conversation internally about whether we want to support custom plugins as a skill
they're very, very good for particular use-cases but can easily become pretty expensive footguns in terms of time and actual dollars (based on how we've seen some folks use them in the wild)
DaleSeo
left a comment
DaleSeo
left a comment
There was a problem hiding this comment.
Thanks for sharing your expertise in creating router plugins, @samuelAndalon! I don’t know much about router plugins, so I only have a couple of minor comments on the frontmatter. The router team will give it a thorough review.
| > **Official diagram:** [Apollo Router Request Lifecycle](https://www.apollographql.com/docs/graphos/routing/customization/rhai#router-request-lifecycle) | ||
|
|
||
| ``` | ||
| REQUEST FLOW (left to right) |
There was a problem hiding this comment.
should this be a mermaid diagram instead?
There was a problem hiding this comment.
I can update it to use a flow diagram and ascii render it with https://github.com/lukilabs/beautiful-mermaid
aaronArinder
dismissed
their stale review
can't commit to a review/approval; but, dismissing to get out of the way of the AI tooling folks
4 participants
No description provided.