Skip to content

Conversation

@loganprosser
Copy link
Collaborator

  • Actual implementation of History Updates last PR didn't implement any changes or any new code
  • Implemented datatables into the history page allows users to search for specific entries and sort by testing field
  • reworked how unique entries are done, now a filter at the top of the history page uses a db.session query
  • updated all other pages to now work with new history page
  • improved history page ui (need to add sometype of loading bar or spinner eventually)
  • data table scales with users window size and uses a scroller to stay responsive with large datasets
  • added temporary add_dummy_entry function that creates random data entries to populate history page with N random entries called with http://localhost:5001/add_dummy_entry?count=N
  • base.html now has additional datatables imports to support new history page
  • print .csv prints unique only .csv when on unique only history page

pwittich
pwittich previously approved these changes Jun 19, 2025
Copy link
Contributor

@pwittich pwittich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pwittich
Copy link
Contributor

actually @prosserlogan this again has conflicts -- somehow this is a recurring issue....

@loganprosser loganprosser dismissed pwittich’s stale review June 19, 2025 20:31

The merge-base changed after approval.

@loganprosser
Copy link
Collaborator Author

ok i think all conflicts are good now

Copy link
Contributor

@pwittich pwittich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again

@loganprosser loganprosser merged commit 1435a9a into main Jun 20, 2025
3 checks passed
@loganprosser loganprosser deleted the history_updates branch June 24, 2025 14:40
loganprosser added a commit that referenced this pull request Jul 23, 2025
loganprosser added a commit that referenced this pull request Jul 23, 2025
loganprosser added a commit that referenced this pull request Jul 23, 2025
loganprosser added a commit that referenced this pull request Jul 25, 2025
* apply history_updates changes onto #7 main base

* clear history and saves and add saves admin functions, added saveable forms not fully implemented, added dashboard to view users saved forms

* fixed pylint

* finished storing feature as of now does not save in progress files, as in if you submit a file then leave current page file will be lost

* fixed issue when user tries to save and serial number is invalid

* added admin check, fishy_user log, and changed creation of test (dummy) entires to allow for seperate deletion of test objects from real test data

* addressed 3000 magic number

* pylint test

* fixed pylint errors from merge with main

* adjusted forms fields with request in issue #9

* fixing new form entries

* fixed constant

* fixed saving file submissions in form save feature

* switched uiud to timestamp for fileupload

* added download links to history table for uploaded files

* added fail test button to forms which prompts user for a failure reason and makes all remaining fields null incase of significant test failure

* added new failure fields to csv download

* added new history page listing all fields with help_text or help_link, moved apollo prod test to .../prod_test_doc

* fixed errors in FormField Class and disabled for this commit

* made new FormField Class to make updating and keeping track of forms easier, forms now writtend from form_config.py and put back into dictionaries to be used by routes which expect dictionaries

* changed formField type to type_field

* changed lambda to function in form_config

* renamed type to type_field for all templates and routes in app.py

* finished updating i2c tests for help page and tried to make ui better adjusted how FormField works now allowing addition of help_instance fields to make help page better

* fixed form renaming

* made ui better maybe need to remove gradient or switch it around more

* more test updates

* character limits on text fields

* making positional arguments keywords

* added * to constructors

* added explicit names for formfield obejcts

* anything

* changed download csv to javascript to donwload only what is filtered

* fixed errors

* added clickable red help links to forward to help_target or deticated help_label in help page

* uploaded files
now named CMXXXX-timestamp-filename and located in uploads/CMXXXX directory

* fixed help page expandable cards & slightly updated ui for i index and form_complete pages, also added dynamic sizing to the history page table

* added graphics to home page and fixed save forms

* removed unnecessary file names

* changed form route, process_file_fields, validate_value, and get_value to use FormField object not the dictionary conversion

* updated history route and .html and download csv route to work with formfield not dictionaries

* changed dashboard and determine_step_from_data to use formfields

* changed saved fields to be test entries so they can be viewded while being updted, changed the save dashboard to be global now using a lock system per user where multiple users can edit a single form when released, changed the form structure to require the first form to be a singlular field for the serial number (asserts included now), added auto refresh toggle to dashboard

* fixed errors removed second declaration of current_user()get_current_user -> current_user

* fixed whitespace

* added serial lock to only allow one save per serial, fully moved form route to use FORM_NON_DICT, updated the test failure function to work with new testentries as stored, updated current_user()

* all forms are now submitted as in progress test entries tviewable from table on form next

* added admin dashboard to view all inprogress entries and clear lock / delete them deleted locks are saved to an admin only database with information about who deleted and all form data dispalyed

* seperated admin routes into admin_routes, put utility functions into utils.py

* fixed unused imports, app -> current_app from flask

* used dict literal instead of dict(...)

* resumable test failure for all users implemented

* fixed spacings

* prevent two people restatring from failure no lock and key tho

* added parent and parent_id to TestEntry to keep track of history lineage, shown only in failed test page as of now later to go into history

* formatting changes

* fixed double sumbission and submission lock

* test

* switched single db into two: main bind key -> test.db and users -> users.db, added new admin help function to list all commands, added constants file to replace repeated constant declarations, added new demote_admin promote_user and add_admin commands to manage admin access for users

* switched single db into two: main bind key -> test.db and users -> users.db, added new admin help function to list all commands, added constants file to replace repeated constant declarations, added new demote_admin promote_user and add_admin commands to manage admin access for users

* switched single db into two: main bind key -> test.db and users -> users.db, added new admin help function to list all commands, added constants file to replace repeated constant declarations, added new demote_admin promote_user and add_admin commands to manage admin access for users

* switched single db into two: main bind key -> test.db and users -> users.db, added new admin help function to list all commands, added constants file to replace repeated constant declarations, added new demote_admin promote_user and add_admin commands to manage admin access for users

* switched single db into two: main bind key -> test.db and users -> users.db, added new admin help function to list all commands, added constants file to replace repeated constant declarations, added new demote_admin promote_user and add_admin commands to manage admin access for users

* added docstrings

* added default users database with logan as admin

* hashing now on client side too for extra security, create admin now uses default register page

* hashing now on client side too for extra security, create admin now uses default register page

* rewrote form route with improved structure, got rid of entryslot storage

* fixed unused errors

* implement solution for issue #12

* fixed handling of saved forms and fail foms with one form per user update

* restricting admin creation

* removed script

* fixed errors from merge

* removed master account

* fixed whitspace errr

* fixed broken DeletedEntry class

* fixed form failure overwrite bug

* fixed errors in TestEntry.is_finished == False -> is False

* Update templates/dashboard.html

Co-authored-by: Peter Wittich <pwittich@users.noreply.github.com>

* removed users.db

* deleted repeated users bind key

---------

Co-authored-by: logan <prosserlogan@github.com>
Co-authored-by: Peter Wittich <pwittich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants