Change attacks to use damage and energy requirements from database#23
Merged
apmnt merged 2 commits intoapmnt:mainfrom Oct 27, 2025
Merged
Change attacks to use damage and energy requirements from database#23apmnt merged 2 commits intoapmnt:mainfrom
apmnt merged 2 commits intoapmnt:mainfrom
Conversation
Owner
|
Thanks for the work, looks good. Those shared references have definitely given me trouble before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A huge step towards being fully compatible with the database file from deckgym. I think the only remaining field is the "is_ex" field. I originally wanted to complete this feature before creating this PR but since I'll be away the entire of next week, I'm making this PR now.
The original attacks are still in attack_common.py and should probably be cleaned-up since all the data will eventually be sourced from the database.json file.